fix(proxy): correct userinfo validation logic #60476
Conversation
Fix(proxy): correct userinfo validation logic - Fix incorrect length check by using userinfo.length instead of proxy.length
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/420381 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
|
Thank you for the fix. Could you add a test to |
I will add it later |
|
Hi @aapelismith thanks much for the contribution? Still working on that test? |
|
@aapelismith any updates? We will have to close this if we do not hear from you. |
|
I think we should land a fix and add a test ourselves because the bug is real cc @brianquinlan |
|
@mit-mit I haven't had time to deal with this issue recently. Is anyone willing to take over? |
|
Sorry, I missed the discussion on this PR - I'll add the tests and land the PR. Thanks for your work on this @aapelismith ! |
… validate proxy passwords. Closes #60476 GitOrigin-RevId: c2f3b31 Change-Id: I498dcfae0b0c9614fc388f102f8d88630e0761ef Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420381 Reviewed-by: Siva Annamalai <[email protected]> Commit-Queue: Brian Quinlan <[email protected]>
|
Thanks @aapelismith !! 🙏 |
fix(proxy): correct userinfo validation logic
export http_proxy=http://aaaaaaaaaaaaa:1234567891234567@localhost:8088, this error was triggered and incorrect validation logic was foundContribution guidelines:
dart format.Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.